From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Cummins Subject: Re: [PATCH] assembler: Add a regions visualizer tool Date: Tue, 19 Mar 2013 10:49:24 +0000 Message-ID: <20130319104924.GA2638@chris.x230> References: <1363110781-27837-1-git-send-email-christopher.e.cummins@intel.com> <20130318160441.GA3390@dyon.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 94335E5CD2 for ; Tue, 19 Mar 2013 03:49:26 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130318160441.GA3390@dyon.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Hi Damien, thanks a lot for the review. On Mon, Mar 18, 2013 at 04:04:42PM +0000, Damien Lespiau wrote: > A quick review trying to use the tool: > > * I think it'd be better if byte 0 is at the right, it seems to be the > usual ways to represent registers, lower bits at the right. > * there's a bug when giving advanced=1 on the URL, the tool doesn't > seem to take it into account > * it'd be nice to get rid of the trailing white space (no review would > be complete without a mention to trailing white space, rule #1 of > the open source world) from the imported js files, I usually use a > script around: > sed -i -e 's,[ \t]*$,,' $file I've pushed a branch to GitHub which implements these improvements, and can be used for temporary work-in-progress before squashing and resubmitting: git://github.com/ChrisCummins/intel-gpu-tools.git wip/gen_regions Regards, Chris