From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 03/20] drm/i915: add constant alpha support to sprite ioctl Date: Tue, 19 Mar 2013 10:57:25 -0700 Message-ID: <20130319105725.325d493c@jbarnes-desktop> References: <1362768363-3710-1-git-send-email-jbarnes@virtuousgeek.org> <1362768363-3710-3-git-send-email-jbarnes@virtuousgeek.org> <20130319084255.GW9021@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy9.bluehost.com (oproxy9.bluehost.com [69.89.24.6]) by gabe.freedesktop.org (Postfix) with SMTP id DCEB7E65D1 for ; Tue, 19 Mar 2013 10:57:20 -0700 (PDT) In-Reply-To: <20130319084255.GW9021@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 19 Mar 2013 09:42:56 +0100 Daniel Vetter wrote: > > --- a/include/uapi/drm/i915_drm.h > > +++ b/include/uapi/drm/i915_drm.h > > @@ -949,6 +949,7 @@ struct drm_intel_overlay_attrs { > > #define I915_SET_COLORKEY_NONE (1<<0) /* disable color key matching */ > > #define I915_SET_COLORKEY_DESTINATION (1<<1) > > #define I915_SET_COLORKEY_SOURCE (1<<2) > > +#define I915_SET_COLORKEY_ALPHA (1<<3) > > We've added this driver-private ioctl before attributes everywhere was > possible. I think we need to convert that before adding more stuff ... > > Also some discussion on dri-devel about a somewhat standardized set of > plane blending properties can't hurt. > > Yes, I know that this will lead to a massive dri-devel bikeshed ;-) Yeah we need some properties for this to fit in with the atomic bits. This patch actually pre-dates that by a bit (it's very old)... I'm sure Ville has ideas on what he'd like to see. -- Jesse Barnes, Intel Open Source Technology Center