From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 14/20] drm/i915: add media well to VLV force wake routines v2 Date: Tue, 19 Mar 2013 20:15:19 +0100 Message-ID: <20130319191519.GA9021@phenom.ffwll.local> References: <1362768363-3710-1-git-send-email-jbarnes@virtuousgeek.org> <1362768363-3710-14-git-send-email-jbarnes@virtuousgeek.org> <20130319115333.GJ4469@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ea0-f172.google.com (mail-ea0-f172.google.com [209.85.215.172]) by gabe.freedesktop.org (Postfix) with ESMTP id DF3F0E5F2A for ; Tue, 19 Mar 2013 12:12:33 -0700 (PDT) Received: by mail-ea0-f172.google.com with SMTP id d10so425358eaj.3 for ; Tue, 19 Mar 2013 12:12:32 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130319115333.GJ4469@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Mar 19, 2013 at 01:53:33PM +0200, Ville Syrj=E4l=E4 wrote: > On Fri, Mar 08, 2013 at 10:45:57AM -0800, Jesse Barnes wrote: > > We could split this out into a separate routine at some point as an > > optimization. > > = > > v2: use FORCEWAKE_KERNEL (Ville) > > = > > Signed-off-by: Jesse Barnes > = > Reviewed-by: Ville Syrj=E4l=E4 > = > With the understanding that no one gets to blame me if the magic > same cacheline register trick turns out to be necessary after all ;) Queued for -next with a tiny bikeshed and a note about this comment added, thanks for the patch. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch