From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 07/15] drm/i915: there's no DSPADDR register on Haswell Date: Wed, 20 Mar 2013 22:44:08 +0100 Message-ID: <20130320214408.GK9021@phenom.ffwll.local> References: <1362611003-4823-1-git-send-email-przanoni@gmail.com> <1362611003-4823-8-git-send-email-przanoni@gmail.com> <20130315191001.GI17773@bwidawsk.net> <20130317203303.GN9021@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f44.google.com (mail-ee0-f44.google.com [74.125.83.44]) by gabe.freedesktop.org (Postfix) with ESMTP id 149B0E5EFD for ; Wed, 20 Mar 2013 14:41:23 -0700 (PDT) Received: by mail-ee0-f44.google.com with SMTP id l10so1386393eei.17 for ; Wed, 20 Mar 2013 14:41:23 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: Ben Widawsky , intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Wed, Mar 20, 2013 at 03:01:34PM -0300, Paulo Zanoni wrote: > Hi > > 2013/3/17 Daniel Vetter : > > On Fri, Mar 15, 2013 at 12:10:02PM -0700, Ben Widawsky wrote: > >> On Wed, Mar 06, 2013 at 08:03:14PM -0300, Paulo Zanoni wrote: > >> > From: Paulo Zanoni > >> > > >> > So don't read it when we hang the GPU. This solves "unclaimed > >> > register" messages. > >> > > >> > Signed-off-by: Paulo Zanoni > >> It would be nice if you could make this a bit more future proof, but > >> looks correct to me: > > > > Done. > > "Done" for intel_display_capture_error_state but not for > intel_display_print_error_state. Do you want to fix this or do you > want me to send a patch on top of dinq? Oh, I've failed again ;-) Yes, please submit a patch since due to the backmerge it'll be a mess to rebase this one out. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch