From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 2/3] Revert "drm/i915: set TRANSCODER_EDP
 even earlier"
Date: Fri, 22 Mar 2013 14:59:23 +0100
Message-ID: <20130322135923.GT9021@phenom.ffwll.local>
References: <1363946021-26651-1-git-send-email-daniel.vetter@ffwll.ch>
	<1363946021-26651-2-git-send-email-daniel.vetter@ffwll.ch>
	<CA+gsUGQCS-UbCDZE3qJhUXrbBUPmR-Rkkbg-pkanSTK6boM+PQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ee0-f52.google.com (mail-ee0-f52.google.com [74.125.83.52])
	by gabe.freedesktop.org (Postfix) with ESMTP id E79C1E6361
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 22 Mar 2013 06:56:36 -0700 (PDT)
Received: by mail-ee0-f52.google.com with SMTP id b15so2231021eek.39
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 22 Mar 2013 06:56:36 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CA+gsUGQCS-UbCDZE3qJhUXrbBUPmR-Rkkbg-pkanSTK6boM+PQ@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>, Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Mar 22, 2013 at 09:30:05AM -0300, Paulo Zanoni wrote:
> 2013/3/22 Daniel Vetter <daniel.vetter@ffwll.ch>:
> > This reverts commit cc464b2a17c59adedbdc02cc54341d630354edc3.
> >
> > The reason is that Takashi Iwai reported a regression bisected to this
> > commit:
> >
> > http://www.mail-archive.com/intel-gfx@lists.freedesktop.org/msg18788.html
> >
> > His machine has eDP on port D (usual desktop all-in-on setup), which
> > intel_dp.c identifies as an eDP panel, but the hsw ddi code
> > mishandles.
> >
> > But in retrospective I also don't like that this leaks highly platform
> > specific details into common code, and the reason is that the drm
> > vblank layer sucks. So instead I think we should:
> > - move the cpu_transcoder into the dynamic pipe_config tracking (once
> >   that's merged).
> > - fix up the drm vblank layer to finally deal with kms crtc objects
> >   instead of int pipes.
> 
> Looks like we'll never get rid of all the unclaimed register errors...
> 
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Picked up for -fixes, thanks for the review.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch