From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] Revert "drm/i915: write backlight harder"
Date: Sat, 23 Mar 2013 12:36:24 +0100
Message-ID: <20130323113624.GX9021@phenom.ffwll.local>
References: <20130322140129.GU9021@phenom.ffwll.local>
	<1363963486-7891-1-git-send-email-daniel.vetter@ffwll.ch>
	<s5hehf7a2zd.wl%tiwai@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f180.google.com (mail-ea0-f180.google.com
	[209.85.215.180])
	by gabe.freedesktop.org (Postfix) with ESMTP id AE243E5D04
	for <intel-gfx@lists.freedesktop.org>;
	Sat, 23 Mar 2013 04:33:37 -0700 (PDT)
Received: by mail-ea0-f180.google.com with SMTP id m14so532733eaj.25
	for <intel-gfx@lists.freedesktop.org>;
	Sat, 23 Mar 2013 04:33:36 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <s5hehf7a2zd.wl%tiwai@suse.de>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Takashi Iwai <tiwai@suse.de>
Cc: Jani Nikula <jani.nikula@intel.com>, Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Mar 22, 2013 at 04:06:14PM +0100, Takashi Iwai wrote:
> At Fri, 22 Mar 2013 15:44:46 +0100,
> Daniel Vetter wrote:
> > 
> > This reverts commit cf0a6584aa6d382f802f2c3cacac23ccbccde0cd.
> > 
> > Turns out that cargo-culting breaks systems. Note that we can't revert
> > further, since
> > 
> > commit 770c12312ad617172b1a65b911d3e6564fc5aca8
> > Author: Takashi Iwai <tiwai@suse.de>
> > Date:   Sat Aug 11 08:56:42 2012 +0200
> > 
> >     drm/i915: Fix blank panel at reopening lid
> > 
> > fixed a regression in 3.6-rc kernels for which we've never figured out
> > the exact root cause. But some further inspection of the backlight
> > code reveals that it's seriously lacking locking. And especially the
> > asle backlight update is know to get fired (through some smm magic)
> > when writing specific backlight control registers. So the possibility
> > of suffering from races is rather real.
> > 
> > Until those races are fixed I don't think it makes sense to try
> > further hacks. Which sucks a bit, but sometimes that's how it is :(
> > 
> > References: http://www.mail-archive.com/intel-gfx@lists.freedesktop.org/msg18788.html
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Takashi Iwai <tiwai@suse.de>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> Feel free to add my tested-by tags to all three.
> 
>   Tested-by: Takashi Iwai <tiwai@suse.de>

Picked up for -fixes with the additional kernel bz link for #47941 added.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch