From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2] drm/i915: Warn if a pipe is enabled with a bogus port Date: Mon, 25 Mar 2013 19:21:19 +0100 Message-ID: <20130325182119.GM9021@phenom.ffwll.local> References: <1364224574-22521-1-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f180.google.com (mail-ea0-f180.google.com [209.85.215.180]) by gabe.freedesktop.org (Postfix) with ESMTP id B342AE5D52 for ; Mon, 25 Mar 2013 11:18:31 -0700 (PDT) Received: by mail-ea0-f180.google.com with SMTP id d10so613508eaj.11 for ; Mon, 25 Mar 2013 11:18:30 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Mar 25, 2013 at 02:00:16PM -0300, Paulo Zanoni wrote: > Hi > > 2013/3/25 Damien Lespiau : > > If TRANS_DDI_FUNC_CTL has been wrongly programmed with an incorrect > > port, we are currently trying to read PORT_CLK_SEL(port) with an > > uninitialized value. > > > > Handle that case by returning PORT_CLK_SEL_NONE and warning about it. > > > > v2: Move the warning inside intel_ddi_get_crtc_pll (Paulo Zanoni) > > > > Signed-off-by: Damien Lespiau > > Reviewed-by: Paulo Zanoni Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch