From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 2/8] drm/i915: Set hotplug_supported_flag
 for all chipset generations.
Date: Tue, 26 Mar 2013 12:51:06 -0700
Message-ID: <20130326125106.0d606291@jbarnes-desktop>
References: <1357830166-18049-1-git-send-email-eich@suse.de>
	<1357830166-18049-3-git-send-email-eich@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy6-pub.bluehost.com (oproxy6-pub.bluehost.com
	[67.222.54.6])
	by gabe.freedesktop.org (Postfix) with SMTP id 5AF29E61BE
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 26 Mar 2013 12:50:52 -0700 (PDT)
In-Reply-To: <1357830166-18049-3-git-send-email-eich@suse.de>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Egbert Eich <eich@suse.de>
Cc: Daniel Vetter <daniel.vetter@intel.com>, intel-gfx@lists.freedesktop.org, Chris Wilson <chris.wilson@intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 10 Jan 2013 10:02:40 -0500
Egbert Eich <eich@suse.de> wrote:

> So far the hotplug_supported_mask in the struct drm_i915_private
> is only used for pre-Ironlake chipsets.
> This patch sets up the correct value for all generations.
> 
> Signed-off-by: Egbert Eich <eich@suse.de>
> ---
>  drivers/gpu/drm/i915/i915_drv.h   |    4 ++
>  drivers/gpu/drm/i915/i915_irq.c   |   71 +++++++++++++++++++++++++++++++++++++
>  drivers/gpu/drm/i915/intel_crt.c  |    2 +-
>  drivers/gpu/drm/i915/intel_dp.c   |    4 +--
>  drivers/gpu/drm/i915/intel_hdmi.c |    4 +--
>  drivers/gpu/drm/i915/intel_sdvo.c |   12 +------
>  6 files changed, 79 insertions(+), 18 deletions(-)

I like it.

Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Just a tiny style nitpick.  I'd prefer:

+	/* SDVO is treated separately */
+	if (IS_IVYBRIDGE(dev) ||
+	    IS_HASWELL(dev) ||
+	    (HAS_PCH_SPLIT(dev) && HAS_PCH_CPT(dev))) {

to be

+	/* SDVO is treated separately */
+	if (IS_IVYBRIDGE(dev) || IS_HASWELL(dev) ||
+	    (HAS_PCH_SPLIT(dev) && HAS_PCH_CPT(dev))) {

instead because vertical space is precious.  But that's definitely not
worth delaying this patch over.

-- 
Jesse Barnes, Intel Open Source Technology Center