From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 4/8] drm/i915: Add Hotplug IRQ Storm
 detection.
Date: Tue, 26 Mar 2013 12:59:37 -0700
Message-ID: <20130326125937.1673f7ec@jbarnes-desktop>
References: <1357830166-18049-1-git-send-email-eich@suse.de>
	<1357830166-18049-5-git-send-email-eich@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy1-pub.bluehost.com (oproxy1-pub.bluehost.com
	[66.147.249.253])
	by gabe.freedesktop.org (Postfix) with SMTP id 07E51E614B
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 26 Mar 2013 12:59:21 -0700 (PDT)
In-Reply-To: <1357830166-18049-5-git-send-email-eich@suse.de>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Egbert Eich <eich@suse.de>
Cc: Daniel Vetter <daniel.vetter@intel.com>, intel-gfx@lists.freedesktop.org, Chris Wilson <chris.wilson@intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 10 Jan 2013 10:02:42 -0500
Egbert Eich <eich@suse.de> wrote:

> +		if (hotplug_trigger & intel_connector->hpd_status_bit) {
> +			if (jiffies > (intel_connector->last_hpd_jiffies + msecs_to_jiffies(1000)) ||
> +			    jiffies < intel_connector->last_hpd_jiffies) {

Can you use time_after() here instead?

Otherwise this looks really nice.  We should get it lots of testing and
soak time.

Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center