From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 8/9] drm/i915: treat no fb -> fb as simple flip instead of full mode set Date: Wed, 27 Mar 2013 01:03:33 +0100 Message-ID: <20130327000333.GE9021@phenom.ffwll.local> References: <1364340792-7278-1-git-send-email-jbarnes@virtuousgeek.org> <1364340792-7278-9-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com [74.125.83.41]) by gabe.freedesktop.org (Postfix) with ESMTP id B550FE5F10 for ; Tue, 26 Mar 2013 17:00:44 -0700 (PDT) Received: by mail-ee0-f41.google.com with SMTP id c1so1637981eek.14 for ; Tue, 26 Mar 2013 17:00:44 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1364340792-7278-9-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Mar 26, 2013 at 04:33:11PM -0700, Jesse Barnes wrote: > In case we don't get an fb from the BIOS, we may still be able to re-use > existing state and flip a new buffer. > > Signed-off-by: Jesse Barnes This hack here smells extremely fishy. Where do we come up with no fb, but a real mode and want to actually fastboot? -Daniel > --- > drivers/gpu/drm/i915/intel_display.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 0f3c036..f24da1a 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -8109,10 +8109,8 @@ intel_set_config_compute_mode_changes(struct drm_mode_set *set, > /* We should be able to check here if the fb has the same properties > * and then just flip_or_move it */ > if (set->crtc->fb != set->fb) { > - /* If we have no fb then treat it as a full mode set */ > if (set->crtc->fb == NULL) { > - DRM_DEBUG_KMS("crtc has no fb, full mode set\n"); > - config->mode_changed = true; > + config->fb_changed = true; > } else if (set->fb == NULL) { > config->mode_changed = true; > } else if (set->fb->depth != set->crtc->fb->depth) { > -- > 1.7.9.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch