From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 10/13] drm/i915: convert DP autodither code to new infrastructure Date: Wed, 27 Mar 2013 14:13:18 -0700 Message-ID: <20130327141318.2226d053@jbarnes-desktop> References: <1364341502-1184-1-git-send-email-daniel.vetter@ffwll.ch> <1364341502-1184-11-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy14-pub.unifiedlayer.com (oproxy14-pub.unifiedlayer.com [67.222.51.224]) by gabe.freedesktop.org (Postfix) with SMTP id 1B528E64F4 for ; Wed, 27 Mar 2013 14:13:03 -0700 (PDT) In-Reply-To: <1364341502-1184-11-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Wed, 27 Mar 2013 00:44:59 +0100 Daniel Vetter wrote: > The old code only handled either 6bpc or 8bpc. Since it's easy to do, > reorganize the code to be a bit more generic so that it can also handle > 10bpc and 12bpc. Note that we still start with 8bpc, so there's no > functional change. > > Also, since we no don't need to compute the 6BPC flag in the mode_valid > callback, we can consolidate things a bit. That requires though that > the link bw computation is moved up in the compute_config callback. > > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/intel_display.c | 4 -- > drivers/gpu/drm/i915/intel_dp.c | 103 ++++++++++++++++------------------- > drivers/gpu/drm/i915/intel_drv.h | 3 - > 3 files changed, 47 insertions(+), 63 deletions(-) > I had a harder time following this one (DP is just complex), but it looks ok so far. I'll feel better with lots of testing. Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center