From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: clear crt hotplug compare voltage
 field before setting
Date: Wed, 27 Mar 2013 16:41:04 +0100
Message-ID: <20130327154104.GB2228@phenom.ffwll.local>
References: <20130327140316.GA4469@intel.com>
	<1364395631-27934-1-git-send-email-daniel.vetter@ffwll.ch>
	<20130327150243.GC4469@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f175.google.com (mail-ea0-f175.google.com
	[209.85.215.175])
	by gabe.freedesktop.org (Postfix) with ESMTP id A850AE6056
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 27 Mar 2013 08:38:16 -0700 (PDT)
Received: by mail-ea0-f175.google.com with SMTP id r16so790473ead.34
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 27 Mar 2013 08:38:15 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130327150243.GC4469@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Mar 27, 2013 at 05:02:43PM +0200, Ville Syrj=E4l=E4 wrote:
> On Wed, Mar 27, 2013 at 03:47:11PM +0100, Daniel Vetter wrote:
> > Noticed while reviewing the hotplug irq setup code. Just looks better.
> > =

> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> =

> Reviewed-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>

Queued for -next, thanks for the review.

> What about the activation period? Do we want to leave it alone on non
> g4x platforms, or should it also get cleared?

The activation period is just one bit, so setting it will dtrt. And there
are other values to tune the crt hotplug detection, so I've figured I'll
leave things as-is otherwise. The lack of proper masking just annoyed my
OCD a bit ;-)
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch