From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 03/13] drm/i915: add pipe_config->timings_set Date: Wed, 27 Mar 2013 17:59:26 +0100 Message-ID: <20130327165926.GE2228@phenom.ffwll.local> References: <1364341502-1184-1-git-send-email-daniel.vetter@ffwll.ch> <1364341502-1184-4-git-send-email-daniel.vetter@ffwll.ch> <20130327094952.7656a845@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f50.google.com (mail-ee0-f50.google.com [74.125.83.50]) by gabe.freedesktop.org (Postfix) with ESMTP id 90C83E617C for ; Wed, 27 Mar 2013 09:56:37 -0700 (PDT) Received: by mail-ee0-f50.google.com with SMTP id e53so1066199eek.37 for ; Wed, 27 Mar 2013 09:56:36 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130327094952.7656a845@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Wed, Mar 27, 2013 at 09:49:52AM -0700, Jesse Barnes wrote: > Changelog and summary could be better and mention the new > compute_config function and how it replaces the mode_fixup one. > > Also, TIMINGS_SET probably wasn't a very good name in the first place, > since it really deals with letter/pillar box configs. But that's not > really a problem with your patch and could be changed in a follow-on. > > Reviewed-by: Jesse Barnes Well, I've missed to add a commit addition discussed with Ville: > > -- > Jesse Barnes, Intel Open Source Technology Center > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch