From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 07/13] drm/i915: check panel fit status at
 update_plane time v2
Date: Tue, 2 Apr 2013 11:00:53 -0700
Message-ID: <20130402110053.3c9c6acb@jbarnes-desktop>
References: <1364922237-3620-1-git-send-email-jbarnes@virtuousgeek.org>
	<1364922237-3620-8-git-send-email-jbarnes@virtuousgeek.org>
	<20130402175837.GW2228@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy14-pub.unifiedlayer.com (oproxy14-pub.unifiedlayer.com
	[67.222.51.224])
	by gabe.freedesktop.org (Postfix) with SMTP id 1541FE5C74
	for <intel-gfx@lists.freedesktop.org>;
	Tue,  2 Apr 2013 11:00:56 -0700 (PDT)
In-Reply-To: <20130402175837.GW2228@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, 2 Apr 2013 19:58:37 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:

> On Tue, Apr 02, 2013 at 10:03:51AM -0700, Jesse Barnes wrote:
> > We may need to disable the panel when flipping to a new buffer, so check
> > the state here and zero it out if needed, otherwise leave it alone.
> > 
> > v2: fixup pipe_set_base check (Imre)
> > 
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> 
> tbh I have no idea yet how we should best handle this and the following
> patch. My current guess is that we need a special pipe_update path, which
> sits in between the fb_update and the full modeset we currently have. A
> bunch of things we might want to do in that case:
> - kill the vga plane
> - update watermarks to our (hopefully power-efficient) ones
> - adjust pfit state (the bios tends to enable that even on non-lvds/edp
>   outputs)
> - update other/global pm state (power well, refclocks, ...)
> - update infoframes/audio bits (not relevant for panels luckily)
> 
> Of course I'd prefer if the code is somehow shared between the update_pipe
> path and the full modeset, since we'll inevitably get something wrong ...

Agree that we should share code paths where possible.

I think we could add new paths in enable/disable crtc for adjusting the
global state.  pfit would probably fit better there anyway, since it's
not really panel specific.

-- 
Jesse Barnes, Intel Open Source Technology Center