From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 1/8] drm/i915: clear up the fdi/dp set_m_n confusion Date: Tue, 2 Apr 2013 13:47:52 -0700 Message-ID: <20130402134752.6207a0a9@jbarnes-desktop> References: <1364463723-30252-1-git-send-email-daniel.vetter@ffwll.ch> <1364463723-30252-2-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy7-pub.bluehost.com (oproxy7-pub.bluehost.com [67.222.55.9]) by gabe.freedesktop.org (Postfix) with SMTP id D74A3E5C49 for ; Tue, 2 Apr 2013 13:47:48 -0700 (PDT) In-Reply-To: <1364463723-30252-2-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Thu, 28 Mar 2013 10:41:56 +0100 Daniel Vetter wrote: > > + /* DP has a bunch of special case unfortunately, so mark the pipe > + * accordingly. */ > + bool has_dp_encoder; Looks pretty good, but I don't think this field is used anywhere? Maybe it belongs in a later patch? Also, this makes me wonder if we should be clearing the m_n regs somewhere and asserting for them in a few places. Definitely looks better than the current code though; CPU vs PCH writes sprinkled all about, and FDI thrown into the mix. It's probably a bit unfair to say the HSW mode set is confused though; it's just using existing code as best it can. These new bits are definitely clearer though. -- Jesse Barnes, Intel Open Source Technology Center