From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 7/8] drm/i915: create pipe_config->dpll for
 clock state
Date: Wed, 3 Apr 2013 11:44:13 +0200
Message-ID: <20130403094413.GL2228@phenom.ffwll.local>
References: <1364463723-30252-1-git-send-email-daniel.vetter@ffwll.ch>
	<1364463723-30252-8-git-send-email-daniel.vetter@ffwll.ch>
	<20130402141423.1035829f@jbarnes-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ee0-f48.google.com (mail-ee0-f48.google.com [74.125.83.48])
	by gabe.freedesktop.org (Postfix) with ESMTP id 13261E5CEC
	for <intel-gfx@lists.freedesktop.org>;
	Wed,  3 Apr 2013 02:41:17 -0700 (PDT)
Received: by mail-ee0-f48.google.com with SMTP id b15so578403eek.7
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 03 Apr 2013 02:41:17 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130402141423.1035829f@jbarnes-desktop>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Apr 02, 2013 at 02:14:23PM -0700, Jesse Barnes wrote:
> This one's hard to review since you mixed in a drm_crtc->intel_crtc
> function arg change.
> 
> I'd rather have that split out, but it looks ok.

Yeah, I've fumbled this one a bit, but decided to punt on the split-up.

Generally I'm always a bit unsure when exactly we should do rote
refactoring like this: We have a similar conversion going on from
drm_encoder->intel_encoder, also with the switch away from the drm crtc
helper vtables to our own.
 
Usually I don't switch code I don't yet touch (Paulo complained about
that, too) since such massive sed jobs simply make patch rebasing complete
hell. Both for me, but also for anyone else with an in-flight patch series
touching the same area. But once in a while I get fed up and convert a few
more things while touching them, leading the slightly ugly patches ...

> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Thanks for the review, entire series is merged for -next.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch