From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 3/3] drm/i915: Don't use the HDMI port color range bit on Valleyview Date: Wed, 3 Apr 2013 19:08:00 +0200 Message-ID: <20130403170800.GP2228@phenom.ffwll.local> References: <1364908210-13748-1-git-send-email-ville.syrjala@linux.intel.com> <1364908210-13748-4-git-send-email-ville.syrjala@linux.intel.com> <87zjxgrmac.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ea0-f173.google.com (mail-ea0-f173.google.com [209.85.215.173]) by gabe.freedesktop.org (Postfix) with ESMTP id 6A27BE5CDD for ; Wed, 3 Apr 2013 10:05:04 -0700 (PDT) Received: by mail-ea0-f173.google.com with SMTP id k11so726564eaj.18 for ; Wed, 03 Apr 2013 10:05:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87zjxgrmac.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Apr 03, 2013 at 12:33:31PM +0300, Jani Nikula wrote: > On Tue, 02 Apr 2013, ville.syrjala@linux.intel.com wrote: > > From: Ville Syrj=E4l=E4 > > > > VLV docs still list the the color range selection bit for the HDMI > > ports, but for DP ports it has been repurposed. > > > > I have no idea whether the HDMI color range selection bit still works > > on VLV, but since we now have to use the PIPECONF color range bit for > > DP, we might as well do the same for HDMI. > = > I don't have any additional information on this. The patch does what it > says above, so for that: > = > Reviewed-by: Jani Nikula Patches 2/3 also queued for -next, thanks for the patch. -Daniel > = > = > > > > Signed-off-by: Ville Syrj=E4l=E4 > > --- > > drivers/gpu/drm/i915/intel_hdmi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/i= ntel_hdmi.c > > index b206a0d..ee4a8da 100644 > > --- a/drivers/gpu/drm/i915/intel_hdmi.c > > +++ b/drivers/gpu/drm/i915/intel_hdmi.c > > @@ -602,7 +602,7 @@ static void intel_hdmi_mode_set(struct drm_encoder = *encoder, > > u32 hdmi_val; > > = > > hdmi_val =3D SDVO_ENCODING_HDMI; > > - if (!HAS_PCH_SPLIT(dev)) > > + if (!HAS_PCH_SPLIT(dev) && !IS_VALLEYVIEW(dev)) > > hdmi_val |=3D intel_hdmi->color_range; > > if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC) > > hdmi_val |=3D SDVO_VSYNC_ACTIVE_HIGH; > > -- = > > 1.8.1.5 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch