From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: re-add eDP bpp clamping notice Date: Thu, 4 Apr 2013 01:31:18 +0200 Message-ID: <20130403233118.GU2228@phenom.ffwll.local> References: <1365022982-28745-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f43.google.com (mail-ee0-f43.google.com [74.125.83.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 02C81E5DFE for ; Wed, 3 Apr 2013 16:28:21 -0700 (PDT) Received: by mail-ee0-f43.google.com with SMTP id e50so858280eek.2 for ; Wed, 03 Apr 2013 16:28:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1365022982-28745-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Wed, Apr 03, 2013 at 11:03:02PM +0200, Daniel Vetter wrote: > This has been lost in my recent bpp handling rework in > > commit 4e53c2e010e531b4a014692199e978482d471c7e > Author: Daniel Vetter > Date: Wed Mar 27 00:44:58 2013 +0100 > > drm/i915: precompute pipe bpp before touching the hw > > Cc: Paulo Zanoni > Signed-off-by: Daniel Vetter I think we can disregard this patch since my next pipe-config series will touch this some more and add a real debug output again. I'll (re) submit that pile tomorrow. -Daniel > --- > drivers/gpu/drm/i915/intel_dp.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index c5cfec3..58ba0a0 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -741,8 +741,11 @@ intel_dp_compute_config(struct intel_encoder *encoder, > /* Walk through all bpp values. Luckily they're all nicely spaced with 2 > * bpc in between. */ > bpp = min_t(int, 8*3, pipe_config->pipe_bpp); > - if (is_edp(intel_dp) && dev_priv->edp.bpp) > + if (is_edp(intel_dp) && dev_priv->edp.bpp) { > + DRM_DEBUG_KMS("clamping display bpc (was %d) to eDP (%d)\n", > + bpp, dev_priv->edp.bpp); > bpp = min_t(int, bpp, dev_priv->edp.bpp); > + } > > for (; bpp >= 6*3; bpp -= 2*3) { > mode_rate = intel_dp_link_required(target_clock, bpp); > -- > 1.7.10.4 > -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch