From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 12/13] drm/i915: fix DP get_hw_state return
 value
Date: Thu, 4 Apr 2013 09:42:53 -0700
Message-ID: <20130404094253.68f62052@jbarnes-t420>
References: <1364922237-3620-1-git-send-email-jbarnes@virtuousgeek.org>
	<1364922237-3620-13-git-send-email-jbarnes@virtuousgeek.org>
	<20130402181105.GX2228@phenom.ffwll.local>
	<20130403231527.GS2228@phenom.ffwll.local>
	<20130403171219.532eb1e3@jbarnes-desktop>
	<CAKMK7uFTfZqGb9hFrCQmzxVHGoScQMFY-EUAQvLNR4RbuXebcg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy13-pub.unifiedlayer.com (oproxy13-pub.unifiedlayer.com
	[69.89.16.30])
	by gabe.freedesktop.org (Postfix) with SMTP id C16D5E644D
	for <intel-gfx@lists.freedesktop.org>;
	Thu,  4 Apr 2013 09:42:56 -0700 (PDT)
In-Reply-To: <CAKMK7uFTfZqGb9hFrCQmzxVHGoScQMFY-EUAQvLNR4RbuXebcg@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 4 Apr 2013 09:56:07 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:

> On Thu, Apr 4, 2013 at 2:12 AM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > On Thu, 4 Apr 2013 01:15:28 +0200
> > Daniel Vetter <daniel@ffwll.ch> wrote:
> >
> >> On Tue, Apr 02, 2013 at 08:11:05PM +0200, Daniel Vetter wrote:
> >> > On Tue, Apr 02, 2013 at 10:03:56AM -0700, Jesse Barnes wrote:
> >> > > If we couldn't find a pipe we shouldn't return true.  This might be even
> >> > > better as a WARN though, since it should be impossible to have the port
> >> > > enabled without a pipe selected.
> >> > >
> >> > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> >> >
> >> > These two fixes are merged for -next, thanks.
> >>
> >> Actually this one here is broken, so I've had to revert it.
> >
> > What failed?  How is it possible we'd have a DP port without a pipe?
> > Every pattern in the register field should correspond to a pipe right?
> 
> Review failed on my side - you've changed the return which is used by
> all the success cases ... There's another return for one failure case,
> and the no-pipe one just falls through. The only case this patch did
> _not_ break is pch ports on cpt/ppt.

Testing fail on my part; I was testing PCH ports but not DP with the
config I had.

Jesse