From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: tune down Y tiling scanout warning
Date: Mon, 8 Apr 2013 10:47:32 +0200
Message-ID: <20130408084732.GJ2228@phenom.ffwll.local>
References: <1365091988-21213-1-git-send-email-daniel.vetter@ffwll.ch>
	<1365285296-10721-1-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f169.google.com (mail-ea0-f169.google.com
	[209.85.215.169])
	by gabe.freedesktop.org (Postfix) with ESMTP id 78FACE5F4E
	for <intel-gfx@lists.freedesktop.org>;
	Mon,  8 Apr 2013 01:44:33 -0700 (PDT)
Received: by mail-ea0-f169.google.com with SMTP id n15so2221938ead.0
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 08 Apr 2013 01:44:32 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1365285296-10721-1-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
List-Id: intel-gfx@lists.freedesktop.org

On Sat, Apr 06, 2013 at 11:54:56PM +0200, Daniel Vetter wrote:
> Userspace can easily hit this and does since Ville added a new evil
> igt testcase in:
> =

> commit 069e35e0fc3785faa562adcfd2dd7bbed4cb1dea
> Author: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> Date:   Mon Mar 4 15:34:06 2013 +0200
> =

>     kms_flip: Add flip-vs-bad-tiling test
> =

> v2: Fix the spelling in the added comment (Chris).
> =

> Cc: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

I've picked this up for next with a reference to the bug QA filed.
-Daniel

> ---
>  drivers/gpu/drm/i915/intel_display.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> =

> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/=
intel_display.c
> index 1b2c744..0e799ea 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -1907,8 +1907,10 @@ intel_pin_and_fence_fb_obj(struct drm_device *dev,
>  		alignment =3D 0;
>  		break;
>  	case I915_TILING_Y:
> -		/* FIXME: Is this true? */
> -		DRM_ERROR("Y tiled not allowed for scan out buffers\n");
> +		/* Despite that we check this in framebuffer_init userspace can
> +		 * screw us over and change the tiling after the fact. Only
> +		 * pinned buffers can't change their tiling. */
> +		DRM_DEBUG_DRIVER("Y tiled not allowed for scan out buffers\n");
>  		return -EINVAL;
>  	default:
>  		BUG();
> -- =

> 1.7.10.4
> =


-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch