From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 2/2] drm/i915: Don't default to overclock max
Date: Tue, 9 Apr 2013 18:58:54 +0200
Message-ID: <20130409165854.GA27612@phenom.ffwll.local>
References: <CAKMK7uFc4EuJUEEPB_hCA_ygsTagXKFUEB6W1+aJKZ8Mma_Gag@mail.gmail.com>
	<1365197363-10218-1-git-send-email-ben@bwidawsk.net>
	<1365197363-10218-2-git-send-email-ben@bwidawsk.net>
	<87k3obyg1v.fsf@gaia.fi.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f171.google.com (mail-ea0-f171.google.com
	[209.85.215.171])
	by gabe.freedesktop.org (Postfix) with ESMTP id 8D1D5E5BF0
	for <intel-gfx@lists.freedesktop.org>;
	Tue,  9 Apr 2013 09:56:05 -0700 (PDT)
Received: by mail-ea0-f171.google.com with SMTP id b15so3022121eae.16
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 09 Apr 2013 09:56:04 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <87k3obyg1v.fsf@gaia.fi.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Ben Widawsky <ben@bwidawsk.net>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Apr 09, 2013 at 04:44:28PM +0300, Mika Kuoppala wrote:
> Ben Widawsky <ben@bwidawsk.net> writes:
> 
> > Requested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> > ---
> >  drivers/gpu/drm/i915/intel_pm.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > index 2edb743..c81921b 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -2632,11 +2632,10 @@ static void gen6_enable_rps(struct drm_device *dev)
> >  		pcu_mbox = 0;
> >  		ret = sandybridge_pcode_read(dev_priv, GEN6_READ_OC_PARAMS, &pcu_mbox);
> >  		if (!ret && (pcu_mbox & (1<<31))) { /* OC supported */
> > -			DRM_DEBUG_DRIVER("overclocking supported, adjusting frequency max from %dMHz to %dMHz\n",
> > +			DRM_DEBUG_DRIVER("Overclocking supported. Max: %dMHz, Overclock max: %dMHz\n",
> >  					 (dev_priv->rps.max_delay & 0xff) * 50,
> >  					 (pcu_mbox & 0xff) * 50);
> Minor nitpick:                                              
> Use GT_FREQUENCY_MULTIPLIER instead of 50

I've ignored that one for now ...

> 
> >  			dev_priv->rps.hw_max = pcu_mbox & 0xff;
> > -			dev_priv->rps.max_delay = pcu_mbox & 0xff;
> >  		}
> >  	} else {
> >  		DRM_DEBUG_DRIVER("Failed to set the min frequency\n");
> > -- 
> > 1.8.2
> 
> Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>

Mika clarified that he indeed reviewed v2 of patch 1 but replied to the
wrong one. Both merged, thanks for the patches.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch