From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH i-g-t v4] tests/gem_tiling_max_stride: Add a test for max fence stride Date: Tue, 9 Apr 2013 20:21:05 +0200 Message-ID: <20130409182105.GF27612@phenom.ffwll.local> References: <20130409135112.GB32417@cantiga.alporthouse.com> <1365518737-23606-1-git-send-email-ville.syrjala@linux.intel.com> <20130409180632.GO3792@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ea0-f181.google.com (mail-ea0-f181.google.com [209.85.215.181]) by gabe.freedesktop.org (Postfix) with ESMTP id 73029E5E54 for ; Tue, 9 Apr 2013 11:18:06 -0700 (PDT) Received: by mail-ea0-f181.google.com with SMTP id z10so2923838ead.12 for ; Tue, 09 Apr 2013 11:18:05 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130409180632.GO3792@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Apr 09, 2013 at 07:06:32PM +0100, Chris Wilson wrote: > On Tue, Apr 09, 2013 at 05:45:37PM +0300, ville.syrjala@linux.intel.com w= rote: > > From: Ville Syrj=E4l=E4 > > = > > gem_tiling_max_stride writes a data pattern to an X-tiled buffer using > > the maximum supported stride, reads the data back as linear, and > > verifies that the data didn't get scrambled on the way. > > = > > The test also checks that some invalid stride values are rejected > > properly. > > = > > v2: Check invalid strides > > v3: Check invalid stride with Y-tiling > > Include a few more invalid stride values > > Fix gen3 X-tile size > > v4: A few more invalid strides :) > > Drop the useless memset() > > = > > Signed-off-by: Ville Syrj=E4l=E4 > = > I think I've exhausted my wishlist, and congrats on finding the bug, so > Reviewed-by: Chris Wilson Merged all three patches, thanks a lot for supplying paranoid igt cases. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch