From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 1/4] drm/i915: keep max backlight internal
 to intel_panel.c
Date: Fri, 12 Apr 2013 13:32:51 +0100
Message-ID: <20130412123251.GD1408@cantiga.alporthouse.com>
References: <cover.1365768957.git.jani.nikula@intel.com>
	<b90fa8acdc137a8a4d92b133cb9e9c8679f7dd11.1365768957.git.jani.nikula@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
	by gabe.freedesktop.org (Postfix) with ESMTP id 33709E6098
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 12 Apr 2013 05:32:55 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <b90fa8acdc137a8a4d92b133cb9e9c8679f7dd11.1365768957.git.jani.nikula@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Apr 12, 2013 at 03:18:36PM +0300, Jani Nikula wrote:
> In preparation of adding locking to backlight, make max backlight value
> (the modulation frequency the PWM duty cycle value must not exceed)
> internal to intel_panel.c.
> 
> Have intel_panel_set_backlight() accept a caller defined range for level,
> and scale input to max backlight value internally.
> 
> Clean up intel_panel_get_max_backlight() and usage internally.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Nice idea,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre