From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 2/2] drm/i915: turbo & RC6 support for VLV v6 Date: Fri, 12 Apr 2013 13:18:32 -0700 Message-ID: <20130412201832.GC27716@bwidawsk.net> References: <1365789045-25509-1-git-send-email-jbarnes@virtuousgeek.org> <1365789045-25509-2-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.localdomain (unknown [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id 13134E5D03 for ; Fri, 12 Apr 2013 13:16:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1365789045-25509-2-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Apr 12, 2013 at 10:50:45AM -0700, Jesse Barnes wrote: > Uses slightly different interfaces than other platforms. > > v2: track actual set freq, not requested (Rohit) > fix debug prints in init code (Jesse) > v3: don't write sleep reg (Jesse) > re-add RC6 wake limit write (Ben) > fixup thresholds to match other platforms (Ben) > clean up mem freq calculation (Ben) > clean up debug prints (Ben) > v4: move defines from punit patch (Ville) > v5: remove writes to nonexistent regs (Jesse) > put RP and RC regs together (Jesse) > fix RC6 enable (Jesse) > v6: use correct fuse reads from NC (Jesse) > split out min/max funcs for use in sysfs (Jesse) > add debugfs & sysfs freq controls (Jesse) > > Signed-off-by: Jesse Barnes I didn't stare too intently since I had reviewed v4, nothing stood out immediately though, so: Reviewed-by: Ben Widawsky [snip] -- Ben Widawsky, Intel Open Source Technology Center