From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH 2/3] drm/i915: don't intel_crt_init on any ULT machines Date: Tue, 16 Apr 2013 10:35:41 +0200 Message-ID: <20130416083541.GG27612@phenom.ffwll.local> References: <1365801414-3576-1-git-send-email-przanoni@gmail.com> <1365801414-3576-2-git-send-email-przanoni@gmail.com> <20130415204500.GB4106@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20130415204500.GB4106@cantiga.alporthouse.com> Sender: stable-owner@vger.kernel.org To: Chris Wilson , Paulo Zanoni , intel-gfx@lists.freedesktop.org, Paulo Zanoni , stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Apr 15, 2013 at 09:45:00PM +0100, Chris Wilson wrote: > On Fri, Apr 12, 2013 at 06:16:53PM -0300, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > We may have DDI_BUF_CTL(PORT_A) configured with 2 lanes and still not > > have CRT, so just check for !IS_ULT. This problem happened on a real > > machine and resulted in a very ugly dmesg. > > > > Cc: stable@vger.kernel.org > > Signed-off-by: Paulo Zanoni > > This doesn't apply to dinq. The approach I'd favour is to have a > intel_info.has_crt similar to the other feature flags. I'm ok with piling checks on top here for now, I guess we should reconsider once the next hw platforms shows up around the corner ... All patches merged to dinq, thanks. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch