From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: implement high-bpc +
 pipeconf-dither support for g4x/vlv
Date: Wed, 24 Apr 2013 00:27:59 +0200
Message-ID: <20130423222759.GL6169@phenom.ffwll.local>
References: <20130419093911.4b4e72dc@jbarnes-desktop>
	<1366395430-7365-1-git-send-email-daniel.vetter@ffwll.ch>
	<20130423152754.GH4469@intel.com>
	<20130423203935.GK6169@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f179.google.com (mail-ea0-f179.google.com
	[209.85.215.179])
	by gabe.freedesktop.org (Postfix) with ESMTP id 2DAA1E5CCB
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 23 Apr 2013 15:24:58 -0700 (PDT)
Received: by mail-ea0-f179.google.com with SMTP id h10so461328eaj.10
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 23 Apr 2013 15:24:57 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130423203935.GK6169@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Apr 23, 2013 at 10:39:35PM +0200, Daniel Vetter wrote:
> On Tue, Apr 23, 2013 at 06:27:54PM +0300, Ville Syrj=E4l=E4 wrote:
> > The g4x docs are a bit confusing though. They seem to indicate the the
> > PIPECONF dither controls only affect DP.
> =

> Hm, this could put a pending question from Jesse at ease whether we should
> still enable dithering in the lvds port register on g4x. Can you point me
> at the relevant bspec language? I didn't spot anything when hunting around
> in the docs ...

Hm, I've done some testing and the pipeconf dithering seems to indeed have
no effect on the lvds panel. I've gotten away since this patch didn't
clear that bit correctly. I'll update the patch. If you can dig out the
Bspec reference, that'd still be great.
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch