From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: simplify DP/DDI port width macros Date: Wed, 24 Apr 2013 14:52:52 +0100 Message-ID: <20130424135252.GA17448@cantiga.alporthouse.com> References: <1366811164-9175-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id C2B30E5D59 for ; Wed, 24 Apr 2013 06:52:57 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1366811164-9175-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development , Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Wed, Apr 24, 2013 at 03:46:04PM +0200, Daniel Vetter wrote: > If we ever leak a non-DP compliant port width through here, we have a > pretty serious issue. So just rip out all these WARNs - if we need > them it's probably better to have them at a central place where we > compute the dp lane count. > > Also use the new DDI width macro for FDI mode. > > Cc: Paulo Zanoni > Signed-off-by: Daniel Vetter Nice. Do we have the central warn though? Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre