From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: factor out GMCH panel fitting code and use for eDP v2 Date: Wed, 24 Apr 2013 18:56:32 +0200 Message-ID: <20130424165632.GX6169@phenom.ffwll.local> References: <1366326349-14374-1-git-send-email-jbarnes@virtuousgeek.org> <87zjwo55pp.fsf@gaia.fi.intel.com> <20130424082921.343fbbab@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f175.google.com (mail-ea0-f175.google.com [209.85.215.175]) by gabe.freedesktop.org (Postfix) with ESMTP id 455A4E5EA3 for ; Wed, 24 Apr 2013 09:53:31 -0700 (PDT) Received: by mail-ea0-f175.google.com with SMTP id f15so842326eak.34 for ; Wed, 24 Apr 2013 09:53:30 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130424082921.343fbbab@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Apr 24, 2013 at 08:29:21AM -0700, Jesse Barnes wrote: > On Wed, 24 Apr 2013 18:05:54 +0300 > Mika Kuoppala wrote: > > > This is different than it was in lvds_compute_config. If we get called > > with DRM_MODE_SCALE_NONE we go to fullscreen instead. > > Is this intentional? > > Yeah, figured I'd make it identical to the eDP case. But we could > change that one instead if you have a preference. SCALE_NONE is rejected in both lvds and edp output's set_property. So not relevant. Maybe we should smash a WARN into the default case instead? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch