From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/4] drm/i915: protect backlight registers and data with a spinlock Date: Thu, 25 Apr 2013 14:13:58 +0200 Message-ID: <20130425121358.GB6169@phenom.ffwll.local> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f180.google.com (mail-ea0-f180.google.com [209.85.215.180]) by gabe.freedesktop.org (Postfix) with ESMTP id 9D30FE637D for ; Thu, 25 Apr 2013 05:10:55 -0700 (PDT) Received: by mail-ea0-f180.google.com with SMTP id q16so1102120ead.25 for ; Thu, 25 Apr 2013 05:10:55 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Apr 12, 2013 at 03:18:37PM +0300, Jani Nikula wrote: > Backlight data and registers are fiddled through LVDS/eDP modeset > enable/disable hooks, backlight sysfs files, asle interrupts, and register > save/restore. Protect the backlight related registers and driver private > fields using a spinlock. > > The locking in register save/restore covers a little more than is strictly > necessary, including non-modeset case, for simplicity. > > v2: Cover register access, save/restore, i915_read_blc_pwm_ctl() and code > paths leading there. > > Signed-off-by: Jani Nikula Merged the first two patches here for next, I guess we can fix up any other issues here separately. Thanks, Daniel ---- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch