From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 7/7] drm/i915: simplify
 config->pixel_multiplier handling
Date: Thu, 25 Apr 2013 14:27:11 +0200
Message-ID: <20130425122711.GD6169@phenom.ffwll.local>
References: <1366362877-15446-1-git-send-email-daniel.vetter@ffwll.ch>
	<1366362877-15446-8-git-send-email-daniel.vetter@ffwll.ch>
	<20130425120832.GB4469@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ee0-f43.google.com (mail-ee0-f43.google.com [74.125.83.43])
	by gabe.freedesktop.org (Postfix) with ESMTP id F2D00E5EBE
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 25 Apr 2013 05:24:07 -0700 (PDT)
Received: by mail-ee0-f43.google.com with SMTP id b47so316062eek.16
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 25 Apr 2013 05:24:07 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130425120832.GB4469@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Apr 25, 2013 at 03:08:32PM +0300, Ville Syrj=E4l=E4 wrote:
> On Fri, Apr 19, 2013 at 11:14:37AM +0200, Daniel Vetter wrote:
> > We only ever check whether it's strictly bigger than one, so all the
> > is_sdvo/is_hdmi checks are redundant. Flatten the code a bit.
> > =

> > Also, s/temp/dpll_md/
> > =

> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> =

> =

> Looks OK. Note that we actually never set pixel_multipler on VLV since
> it doesn't support SDVO, but supposedly it could be used for HDMI too.
> So I guess it doesn't hurt to keep the code for it.

Yeah, finally enabling correct pixel multiplier support for hdmi is on our
eternal todo list. Last time I've tried it something blew up and it didn't
really work out too well. We need to look into this again.
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch