From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Only print the info message about incresing stolen size for FBC once Date: Fri, 26 Apr 2013 16:46:12 +0200 Message-ID: <20130426144612.GM6169@phenom.ffwll.local> References: <1366981465-30683-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com [74.125.83.53]) by gabe.freedesktop.org (Postfix) with ESMTP id 5032FE5F10 for ; Fri, 26 Apr 2013 07:43:09 -0700 (PDT) Received: by mail-ee0-f53.google.com with SMTP id d17so1716651eek.12 for ; Fri, 26 Apr 2013 07:43:08 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1366981465-30683-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Apr 26, 2013 at 02:04:25PM +0100, Chris Wilson wrote: > Instead of repeatedly bombarding the user with a request to reboot and > increase the stolen size with every fb refresh, just inform them the > first time only. > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/intel_pm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index 3534a71..05bc0a4 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -481,8 +481,7 @@ void intel_update_fbc(struct drm_device *dev) > goto out_disable; > > if (i915_gem_stolen_setup_compression(dev, intel_fb->obj->base.size)) { > - DRM_INFO("not enough stolen space for compressed buffer (need %zd bytes), disabling\n", intel_fb->obj->base.size); > - DRM_INFO("hint: you may be able to increase stolen memory size in the BIOS to avoid this\n"); > + pr_info_once("not enough stolen space for compressed buffer (need %zd bytes), disabling. Hint: you may be able to inrease stolen memory size in hte BIOS to avoid this.\n", intel_fb->obj->base.size); s/hte/the/ in the above line while at it? -Daniel > DRM_DEBUG_KMS("framebuffer too large, disabling compression\n"); > dev_priv->no_fbc_reason = FBC_STOLEN_TOO_SMALL; > goto out_disable; > -- > 1.7.10.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch