From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Only print the info message about incresing stolen size for FBC once Date: Fri, 26 Apr 2013 17:43:51 +0200 Message-ID: <20130426154351.GQ6169@phenom.ffwll.local> References: <1366981465-30683-1-git-send-email-chris@chris-wilson.co.uk> <20130426144612.GM6169@phenom.ffwll.local> <20130426150606.GC12865@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f170.google.com (mail-ea0-f170.google.com [209.85.215.170]) by gabe.freedesktop.org (Postfix) with ESMTP id EAB0AE5C6D for ; Fri, 26 Apr 2013 08:40:48 -0700 (PDT) Received: by mail-ea0-f170.google.com with SMTP id z7so1783563eaf.29 for ; Fri, 26 Apr 2013 08:40:48 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130426150606.GC12865@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Apr 26, 2013 at 04:06:06PM +0100, Chris Wilson wrote: > On Fri, Apr 26, 2013 at 04:46:12PM +0200, Daniel Vetter wrote: > > On Fri, Apr 26, 2013 at 02:04:25PM +0100, Chris Wilson wrote: > > > Instead of repeatedly bombarding the user with a request to reboot and > > > increase the stolen size with every fb refresh, just inform them the > > > first time only. > > > > > > Signed-off-by: Chris Wilson > > > --- > > > drivers/gpu/drm/i915/intel_pm.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > > > index 3534a71..05bc0a4 100644 > > > --- a/drivers/gpu/drm/i915/intel_pm.c > > > +++ b/drivers/gpu/drm/i915/intel_pm.c > > > @@ -481,8 +481,7 @@ void intel_update_fbc(struct drm_device *dev) > > > goto out_disable; > > > > > > if (i915_gem_stolen_setup_compression(dev, intel_fb->obj->base.size)) { > > > - DRM_INFO("not enough stolen space for compressed buffer (need %zd bytes), disabling\n", intel_fb->obj->base.size); > > > - DRM_INFO("hint: you may be able to increase stolen memory size in the BIOS to avoid this\n"); > > > + pr_info_once("not enough stolen space for compressed buffer (need %zd bytes), disabling. Hint: you may be able to inrease stolen memory size in hte BIOS to avoid this.\n", intel_fb->obj->base.size); > > s/hte/the/ in the above line while at it? > > The other problem is that we drop the "drm: ", so perhaps we should add > that back in (or start using "drm/i915: " or "i915: "). I've looked through all the macros, and there doesn't seem to be a dev_info_once version. While we discuss debug output, I still wonder whether we should eventually switch over to the dynamic device debug stuff. But I'm not sure whether that's really better than the current scheme. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch