From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 1/7] drm/i915: simplify DP/DDI port width
 macros
Date: Thu, 2 May 2013 21:29:55 +0200
Message-ID: <20130502192955.GG5763@phenom.ffwll.local>
References: <1367323306-13605-1-git-send-email-daniel.vetter@ffwll.ch>
	<1367323306-13605-2-git-send-email-daniel.vetter@ffwll.ch>
	<CA+gsUGShgjtW1heSZBkfbfYb0JfOMcg+hWvG67Wdm13JqNpnTg@mail.gmail.com>
	<20130502145158.GF5763@phenom.ffwll.local>
	<CA+gsUGRqMJWD4OVHc6W-QHoCQQKeKuFB49Fxocc3twrdsYabXw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com
	[209.85.212.172])
	by gabe.freedesktop.org (Postfix) with ESMTP id 31E84E5C91
	for <intel-gfx@lists.freedesktop.org>;
	Thu,  2 May 2013 12:26:52 -0700 (PDT)
Received: by mail-wi0-f172.google.com with SMTP id hm14so954422wib.17
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 02 May 2013 12:26:51 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CA+gsUGRqMJWD4OVHc6W-QHoCQQKeKuFB49Fxocc3twrdsYabXw@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, May 02, 2013 at 02:38:09PM -0300, Paulo Zanoni wrote:
> 2013/5/2 Daniel Vetter <daniel@ffwll.ch>:
> > On Thu, May 02, 2013 at 10:34:23AM -0300, Paulo Zanoni wrote:
> >> 2013/4/30 Daniel Vetter <daniel.vetter@ffwll.ch>:
> >> > If we ever leak a non-DP compliant port width through here, we have a
> >> > pretty serious issue. So just rip out all these WARNs - if we need
> >> > them it's probably better to have them at a central place where we
> >> > compute the dp lane count.
> >> >
> >> > Also use the new DDI width macro for FDI mode.
> >> >
> >> > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> >>
> >> Nice one.
> >>
> >> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > Queued for -next, thanks for the review.
> 
> And now that I've actually booted a Kernel with the patch I see that
> the chunk inside intel_ddi_enable_transcoder_func is wrong. We should
> assign to the "temp" variable, not "intel_dp->DP". This gives me a
> nice black screen on DP.

Oops. Ok, I've pushed an updated version, that one better?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch