From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [Intel-gfx] [PATCH] [TRIVIAL] Fix declaration of
 intel_gmbus_{is_forced_bit/is_port_falid} in i915 driver.
Date: Fri, 3 May 2013 18:16:37 +0200
Message-ID: <20130503161637.GM5763@phenom.ffwll.local>
References: <1367572662-18400-1-git-send-email-dl9pf@gmx.de>
 <20130503092348.GL5763@phenom.ffwll.local>
 <87k3ngtgme.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <87k3ngtgme.fsf@intel.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Daniel Vetter <daniel@ffwll.ch>, dl9pf@gmx.de, airlied@linux.ie, daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, pageexec@freemail.hu
List-Id: intel-gfx@lists.freedesktop.org

On Fri, May 03, 2013 at 03:03:37PM +0300, Jani Nikula wrote:
> On Fri, 03 May 2013, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Fri, May 03, 2013 at 11:17:42AM +0200, dl9pf@gmx.de wrote:
> >> From: Jan-Simon M=C3=B6ller <dl9pf@gmx.de>
> >>=20
> >> Description:
> >> intel_gmbus_is_forced_bit is no extern as its body is right below.
> >> Likewise for intel_gmbus_is_port_valid.
> >>=20
> >> This fixes a compilation issue with clang. An initial version of t=
his patch
> >> was developed by PaX Team <pageexec at freemail.hu>.
> >> This is respin of this patch.
> >>=20
> >> Signed-off-by: Jan-Simon M=C3=B6ller <dl9pf@gmx.de>
> >> CC: pageexec@freemail.hu
> >> CC: daniel.vetter@ffwll.ch
> >> CC: airlied@linux.ie
> >> CC: intel-gfx@lists.freedesktop.org
> >> CC: dri-devel@lists.freedesktop.org
> >> CC: linux-kernel@vger.kernel.org
> > Picked up for -fixes, thanks for the patch.
>=20
> Please drop it.
>=20
> The patch removes the inline keyword, creating dozens of copies of th=
e
> functions, and consequently loads of warnings:
>=20
> drivers/gpu/drm/i915/i915_drv.h:1803:13: warning: =E2=80=98intel_gmbu=
s_is_port_valid=E2=80=99 defined but not used [-Wunused-function]
> drivers/gpu/drm/i915/i915_drv.h:1812:13: warning: =E2=80=98intel_gmbu=
s_is_forced_bit=E2=80=99 defined but not used [-Wunused-function]

Meh, rather embarrassing patch reading fail here. Dropped.

Thanks, Daniel
--=20
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch