From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 2/2] drm/i915: add context into request struct Date: Fri, 3 May 2013 17:07:42 -0700 Message-ID: <20130504000742.GA954@bwidawsk.net> References: <1367502488-4108-1-git-send-email-mika.kuoppala@intel.com> <1367502488-4108-2-git-send-email-mika.kuoppala@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.localdomain (unknown [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id 50E88E5D0C for ; Fri, 3 May 2013 17:05:08 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1367502488-4108-2-git-send-email-mika.kuoppala@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Mika Kuoppala Cc: intel-gfx@lists.freedesktop.org, miku@iki.fi List-Id: intel-gfx@lists.freedesktop.org On Thu, May 02, 2013 at 04:48:08PM +0300, Mika Kuoppala wrote: > Storing context reference into request struct > allows us to inspect context and its associated > objects when requests are retired. > > Both ppgtt and arb robustness work will need > this. > > Signed-off-by: Mika Kuoppala Both 1&2 are: Reviewed-by: Ben Widawsky You should add your sob to 1, since you modified it (slightly), and maybe run them both my Chris to make sure he approves as well. Thanks a lot of reworking the series to this order :D [snip] -- Ben Widawsky, Intel Open Source Technology Center