From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: don't setup hdmi for port D edp in ddi_init Date: Mon, 6 May 2013 11:19:31 +0200 Message-ID: <20130506091931.GV5763@phenom.ffwll.local> References: <1365629315-21878-1-git-send-email-daniel.vetter@ffwll.ch> <20130504094533.GS5763@phenom.ffwll.local> <20130506083157.GB14974@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by gabe.freedesktop.org (Postfix) with ESMTP id 468C4E5EB4 for ; Mon, 6 May 2013 02:16:27 -0700 (PDT) Received: by mail-wi0-f174.google.com with SMTP id m6so2316200wiv.7 for ; Mon, 06 May 2013 02:16:26 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130506083157.GB14974@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Mon, May 06, 2013 at 11:31:57AM +0300, Ville Syrj=E4l=E4 wrote: > On Sat, May 04, 2013 at 11:45:33AM +0200, Daniel Vetter wrote: > > On Wed, Apr 10, 2013 at 11:28:35PM +0200, Daniel Vetter wrote: > > > dp_init_connector adjusts the encoder type if it is a eDP panel. Use > > > that to decide whether we should set up a hdmi connector or not. > > > = > > > To do so reorder the hdmi connector setup sequence in ddi_init a bit. > > > = > > > Signed-off-by: Daniel Vetter > > = > > Does what it says on the tin and works as advertised on my deskop hsw > > machine with edp on port D. Can someone please review? > = > Looks all right to me. > = > Reviewed-by: Ville Syrj=E4l=E4 Queued for -next, thanks for the review. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch