From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/6] drm/i915: PCH_ prefix for transcoder timings Date: Mon, 6 May 2013 11:29:16 +0200 Message-ID: <20130506092916.GY5763@phenom.ffwll.local> References: <20130503091923.GK5763@phenom.ffwll.local> <1367574591-1714-1-git-send-email-daniel.vetter@ffwll.ch> <1367574591-1714-2-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id E5C4CE5F2E for ; Mon, 6 May 2013 02:26:10 -0700 (PDT) Received: by mail-we0-f177.google.com with SMTP id u3so2765191wey.8 for ; Mon, 06 May 2013 02:26:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Fri, May 03, 2013 at 11:16:48AM -0300, Paulo Zanoni wrote: > 2013/5/3 Daniel Vetter : > > While at it, also extract a common helper to copy the timings from the > > cpu transcoder to the pch transcoder. That way it's really explicit > > how the lpt transcoder is hardcoded. > > > > v2: > > - Re-align #defines properly (Paulo). > > - Use cpu_transcoder when copying pipe timings (Paulo). > > - s/intel_pch_transcoder_enable/intel_pch_transcoder_set_timings/ > > since we already have a pch transcoder enable function, and this is > > clearer, too. > > - Fixup 80 char line overflow in intel_display.c. I've opted to ignore > > this in i915_reg.h and i915_ums.c since meh. > > > > Cc: Paulo Zanoni > > Signed-off-by: Daniel Vetter > > Reviewed-by: Paulo Zanoni All patches from this series are now merged, thanks for the review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch