From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 3/4] drm/i915: set proper DPIO post divider for VGA on VLV v4 Date: Mon, 6 May 2013 22:50:29 +0200 Message-ID: <20130506205029.GJ5763@phenom.ffwll.local> References: <1367516890-3469-1-git-send-email-jbarnes@virtuousgeek.org> <1367516890-3469-3-git-send-email-jbarnes@virtuousgeek.org> <5187EDE4.2090501@whitecape.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by gabe.freedesktop.org (Postfix) with ESMTP id 17641E5DE2 for ; Mon, 6 May 2013 13:47:23 -0700 (PDT) Received: by mail-wi0-f173.google.com with SMTP id ey16so2988479wid.6 for ; Mon, 06 May 2013 13:47:23 -0700 (PDT) Content-Disposition: inline In-Reply-To: <5187EDE4.2090501@whitecape.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Kenneth Graunke Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, May 06, 2013 at 10:52:36AM -0700, Kenneth Graunke wrote: > On 05/02/2013 10:48 AM, Jesse Barnes wrote: > >Supposedly we should use the DAC divider for <300MHz pixel clocks, but as > >that doesn't actually work as well as the high freq divider here in > >practice, just use the high freq divider all the time. > > > >v2: remove unconditional write (Jesse) > > check for pixel rate properly (Jesse) > >v3: give up, the DAC divider apparently doesn't work, and low res modes > > work ok (Jesse) > > remove debug msg (Jesse) > > > >Signed-off-by: Jesse Barnes > > VGA is broken with today's drm-intel-next-queued (3a2128bcac1ae). > Applying this patch fixes it. Thanks! > > Tested-by: Kenneth Graunke Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch