From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: BIOS and power context stolen mem handling for VLV v3 Date: Tue, 7 May 2013 20:45:43 +0100 Message-ID: <20130507194543.GC1985@cantiga.alporthouse.com> References: <1367952647-11274-1-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 1CD87E5C65 for ; Tue, 7 May 2013 12:45:46 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1367952647-11274-1-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, May 07, 2013 at 11:50:47AM -0700, Jesse Barnes wrote: > @@ -62,7 +62,10 @@ static unsigned long i915_stolen_to_physical(struct drm_device *dev) > * its value of TOLUD. > */ > base = 0; > - if (INTEL_INFO(dev)->gen >= 6) { > + if (IS_VALLEYVIEW(dev)) { > + pci_read_config_dword(pdev, 0x5c, &base); > + base &= ((1<<20) - 1); Woah, only the low 1 MiB of the physical address is valid? -Chris -- Chris Wilson, Intel Open Source Technology Centre