From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/5] drm: Make the HPD status updates debug logs more readable Date: Wed, 8 May 2013 19:43:18 +0300 Message-ID: <20130508164317.GJ14974@intel.com> References: <1368029014-30181-1-git-send-email-damien.lespiau@intel.com> <1368029014-30181-3-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <1368029014-30181-3-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, May 08, 2013 at 05:03:31PM +0100, Damien Lespiau wrote: > Instead of just printing "status updated from 1 to 2", make those enum > numbers immediately readable. > = > v2: Also patch output_poll_execute() (Daniel Vetter) > = > Signed-off-by: Damien Lespiau > Reviewed-by: Jesse Barnes > --- > drivers/gpu/drm/drm_crtc_helper.c | 22 ++++++++++++++++++---- > 1 file changed, 18 insertions(+), 4 deletions(-) > = > diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc= _helper.c > index 7b2d378..8976eb6 100644 > --- a/drivers/gpu/drm/drm_crtc_helper.c > +++ b/drivers/gpu/drm/drm_crtc_helper.c > @@ -968,6 +968,18 @@ void drm_kms_helper_hotplug_event(struct drm_device = *dev) > } > EXPORT_SYMBOL(drm_kms_helper_hotplug_event); > = > +static const char *connector_status_str(enum drm_connector_status status) > +{ > + switch (status) { > + case connector_status_connected: > + return "connected"; > + case connector_status_disconnected: > + return "disconnected"; > + default: > + return "unknown"; > + } > +} drm_get_connector_status_name() > + > #define DRM_OUTPUT_POLL_PERIOD (10*HZ) > static void output_poll_execute(struct work_struct *work) > { > @@ -1002,10 +1014,11 @@ static void output_poll_execute(struct work_struc= t *work) > continue; > = > connector->status =3D connector->funcs->detect(connector, false); > - DRM_DEBUG_KMS("[CONNECTOR:%d:%s] status updated from %d to %d\n", > + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] status updated from %s to %s\n", > connector->base.id, > drm_get_connector_name(connector), > - old_status, connector->status); > + connector_status_str(old_status), > + connector_status_str(connector->status)); > if (old_status !=3D connector->status) > changed =3D true; > } > @@ -1080,10 +1093,11 @@ void drm_helper_hpd_irq_event(struct drm_device *= dev) > old_status =3D connector->status; > = > connector->status =3D connector->funcs->detect(connector, false); > - DRM_DEBUG_KMS("[CONNECTOR:%d:%s] status updated from %d to %d\n", > + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] status updated from %s to %s\n", > connector->base.id, > drm_get_connector_name(connector), > - old_status, connector->status); > + connector_status_str(old_status), > + connector_status_str(connector->status)); > if (old_status !=3D connector->status) > changed =3D true; > } > -- = > 1.8.1.4 > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- = Ville Syrj=E4l=E4 Intel OTC