From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 34/34] drm/i915: Create VMAs (part 3) Date: Mon, 27 May 2013 08:31:47 +0100 Message-ID: <20130527073053.GC20642@cantiga.alporthouse.com> References: <1369510028-3343-1-git-send-email-ben@bwidawsk.net> <1369510028-3343-35-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D812E609B for ; Mon, 27 May 2013 00:32:14 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1369510028-3343-35-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: Intel GFX List-Id: intel-gfx@lists.freedesktop.org On Sat, May 25, 2013 at 12:27:08PM -0700, Ben Widawsky wrote: > Plumb the functions we care about with VM arguments. > > With the exception of the hack in i915_ppgtt_bind to only ever be able > to do aliasing PPGTT, this most everything we want. Purge is wrong -- it needs to select a victim obj and unbind it from all vma at once, then repeat for a new victim. obj->pin_count is per-vma. Most of the pinning is only relevant for the ggtt (pinned for registers), with other vma only using it for reserve/eviction. But we can remove things from the ppgtt if they are only pinned due to scanout, for example. Do not start introducing i915_obj_* piecemeal, keep it i915_gem_obj_*. debugfs needs more insight into per-vma tracking. -Chris -- Chris Wilson, Intel Open Source Technology Centre