From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [i-g-t PATCH v3 2/2] tests/lib: make sure the GPU is idle at test start and exit Date: Tue, 28 May 2013 18:33:20 +0200 Message-ID: <20130528163320.GD15743@phenom.ffwll.local> References: <1369750978-6040-2-git-send-email-imre.deak@intel.com> <1369751732-19173-1-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f177.google.com (mail-ea0-f177.google.com [209.85.215.177]) by gabe.freedesktop.org (Postfix) with ESMTP id ADE9FE5C5B for ; Tue, 28 May 2013 09:33:25 -0700 (PDT) Received: by mail-ea0-f177.google.com with SMTP id q14so4667189eaj.36 for ; Tue, 28 May 2013 09:33:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1369751732-19173-1-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, May 28, 2013 at 05:35:32PM +0300, Imre Deak wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64270 > > v2: > - Make sure also that the GPU is idle at start and error exit of any > test using drm_open_any(). (Daniel) > v3: > - actually call gem_quiescent_gpu() at exit > > Signed-off-by: Imre Deak Both merged to igt, thanks. -Daniel > --- > lib/drmtest.c | 27 ++++++++++++++++++++++++++- > 1 file changed, 26 insertions(+), 1 deletion(-) > > diff --git a/lib/drmtest.c b/lib/drmtest.c > index 2d37fb6..d17dbb0 100644 > --- a/lib/drmtest.c > +++ b/lib/drmtest.c > @@ -228,7 +228,7 @@ int drm_get_card(int master) > } > > /** Open the first DRM device we can find, searching up to 16 device nodes */ > -int drm_open_any(void) > +static int __drm_open_any(void) > { > char *name; > int ret, fd; > @@ -248,6 +248,31 @@ int drm_open_any(void) > return fd; > } > > +static void quiescent_gpu_at_exit(int sig) > +{ > + int fd; > + > + fd = __drm_open_any(); > + if (fd >= 0) { > + gem_quiescent_gpu(fd); > + close(fd); > + } > +} > + > +int drm_open_any(void) > +{ > + static int open_count; > + int fd = __drm_open_any(); > + > + if (fd < 0 || __sync_fetch_and_add(&open_count, 1)) > + return fd; > + > + gem_quiescent_gpu(fd); > + drmtest_install_exit_handler(quiescent_gpu_at_exit); > + > + return fd; > +} > + > /** > * Open the first DRM device we can find where we end up being the master. > */ > -- > 1.8.1.2 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch