From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 16/18] drm/i915: add VEBOX into debugfs Date: Tue, 28 May 2013 11:44:06 -0700 Message-ID: <20130528184406.GB1464@bwidawsk.net> References: <1367110769-1306-1-git-send-email-ben@bwidawsk.net> <1367110769-1306-17-git-send-email-ben@bwidawsk.net> <20130528150607.GI10995@strange.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.localdomain (unknown [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id D1E72E5E51 for ; Tue, 28 May 2013 11:44:20 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130528150607.GI10995@strange.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Damien Lespiau Cc: Intel-GFX List-Id: intel-gfx@lists.freedesktop.org On Tue, May 28, 2013 at 04:06:07PM +0100, Damien Lespiau wrote: > On Sat, Apr 27, 2013 at 05:59:27PM -0700, Ben Widawsky wrote: > > From: "Xiang, Haihao" > > > > v2 (Ben): s/hsw/hws > > > > Signed-off-by: Xiang, Haihao > > [Order changed, and modified by] > > Signed-off-by: Ben Widawsky > > --- > > drivers/gpu/drm/i915/i915_debugfs.c | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > > index a55630a..71fb7aa 100644 > > --- a/drivers/gpu/drm/i915/i915_debugfs.c > > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > > @@ -379,6 +379,17 @@ static int i915_gem_request_info(struct seq_file *m, void *data) > > } > > count++; > > } > > + if (!list_empty(&dev_priv->ring[VECS].request_list)) { > > + seq_printf(m, "VEBOX requests:\n"); > > + list_for_each_entry(gem_request, > > + &dev_priv->ring[VECS].request_list, > > + list) { > > + seq_printf(m, " %d @ %d\n", > > + gem_request->seqno, > > + (int) (jiffies - gem_request->emitted_jiffies)); > > + } > > + count++; > > + } > > mutex_unlock(&dev->struct_mutex); > > That block doesn't seem necessary as the code above this chuck cycles > over all the rings? Indeed. This is a rebase relic. This hunk is removed. > > > > > if (count == 0) > > @@ -570,6 +581,7 @@ static const char *ring_str(int ring) > > case RCS: return "render"; > > case VCS: return "bsd"; > > case BCS: return "blt"; > > + case VECS: return "vebox"; > > default: return ""; > > } > > } > > @@ -2099,6 +2111,7 @@ static struct drm_info_list i915_debugfs_list[] = { > > {"i915_gem_hws", i915_hws_info, 0, (void *)RCS}, > > {"i915_gem_hws_blt", i915_hws_info, 0, (void *)BCS}, > > {"i915_gem_hws_bsd", i915_hws_info, 0, (void *)VCS}, > > + {"i915_gem_hws_vebox", i915_hws_info, 0, (void *)VECS}, > > {"i915_rstdby_delays", i915_rstdby_delays, 0}, > > {"i915_cur_delayinfo", i915_cur_delayinfo, 0}, > > {"i915_delayfreq_table", i915_delayfreq_table, 0}, > > -- > > 1.8.2.1 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ben Widawsky, Intel Open Source Technology Center