From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 02/18] drm/i915: Semaphore MBOX update generalization Date: Wed, 29 May 2013 17:05:07 +0100 Message-ID: <20130529160507.GE17389@strange.amr.corp.intel.com> References: <1367110769-1306-1-git-send-email-ben@bwidawsk.net> <1369794154-1639-1-git-send-email-ben@bwidawsk.net> <1369794154-1639-3-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id ED45BE60A6 for ; Wed, 29 May 2013 09:05:49 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1369794154-1639-3-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: Intel GFX List-Id: intel-gfx@lists.freedesktop.org On Tue, May 28, 2013 at 07:22:18PM -0700, Ben Widawsky wrote: > This replaces the existing MBOX update code with a more generalized > calculation for emitting mbox updates. We also create a sentinel for > doing the updates so we can more abstractly deal with the rings. > > When doing MBOX updates the code must be aware of the /other/ rings. > Until now the platforms which supported semaphores had a fixed number of > rings and so it made sense for the code to be very specialized > (hardcoded). > > The patch does contain a functional change, but should have no > behavioral changes. > > Signed-off-by: Ben Widawsky Reviewed-by: Damien Lespiau -- Damien