From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: rip out the PM_IIR WARN, again Date: Fri, 31 May 2013 17:22:07 +0200 Message-ID: <20130531152207.GV15743@phenom.ffwll.local> References: <1369984339-15049-1-git-send-email-daniel.vetter@ffwll.ch> <20130531151159.GA19146@strange.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f50.google.com (mail-ee0-f50.google.com [74.125.83.50]) by gabe.freedesktop.org (Postfix) with ESMTP id 850E0E5D0C for ; Fri, 31 May 2013 08:22:12 -0700 (PDT) Received: by mail-ee0-f50.google.com with SMTP id c41so128326eek.37 for ; Fri, 31 May 2013 08:22:11 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130531151159.GA19146@strange.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Damien Lespiau Cc: Daniel Vetter , Intel Graphics Development , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Fri, May 31, 2013 at 04:11:59PM +0100, Damien Lespiau wrote: > On Fri, May 31, 2013 at 09:12:19AM +0200, Daniel Vetter wrote: > > This has accidentally been reintroduced with > > > > commit 22aae764a3fa21ee502b99e8986cb4e49ec14cfe > > Author: Ben Widawsky > > Date: Tue May 28 19:22:24 2013 -0700 > > > > drm/i915: Create a more generic pm handler for hsw+ > > > > See > > > > commit 58bf8062d0b293b8e1028e5b0342082002886bd4 > > Author: Daniel Vetter > > Date: Thu Jun 21 14:55:22 2012 +0200 > > > > drm/i915: rip out the PM_IIR WARN > > > > for the extensive reasoning why the WARN is bogus. > > > > Cc: Damien Lespiau > > Cc: Ben Widawsky > > Cc: Chris Wilson > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=65197 > > Signed-off-by: Daniel Vetter > > --- > > drivers/gpu/drm/i915/i915_irq.c | 7 ++----- > > 1 file changed, 2 insertions(+), 5 deletions(-) > > Reviewed-by: Damien Lespiau > > There's a conflict with the rest of the VECS series, but fortunately > seems like an easy one. Queued for -next, thanks for the review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch