From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 2/4] [v2] drm/i915: Unbind the fb Date: Fri, 31 May 2013 13:08:59 -0700 Message-ID: <20130531200859.GA14189@bwidawsk.net> References: <1370024928-3553-2-git-send-email-ben@bwidawsk.net> <1370025929-14270-1-git-send-email-ben@bwidawsk.net> <20130531193932.GE11399@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.localdomain (unknown [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id 5CB0EE64D3 for ; Fri, 31 May 2013 13:09:02 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130531193932.GE11399@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , Intel GFX List-Id: intel-gfx@lists.freedesktop.org On Fri, May 31, 2013 at 08:39:32PM +0100, Chris Wilson wrote: > On Fri, May 31, 2013 at 11:45:29AM -0700, Ben Widawsky wrote: > > This is the only place I could find where we don't already unbind the > > object before freeing it. This change will allow us to have a nice > > assertion on free about whether or not an object still has pinned pages. > > > > v2: Just use the i915 object instead of casting > > The patch is flawed in that we try to do the unbind without mutex > protection. But it should already be unbound in free_object() anyway - > and doing so here is unlikely to fix the WARN_ON (presuming that is > what you are chasing). > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre Agreed. This patch is junk. I made the mistake of working on it when I should have been in bed. -- Ben Widawsky, Intel Open Source Technology Center