From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 1/2] drm/i915: Make stolen use pin pages Date: Fri, 31 May 2013 14:44:00 -0700 Message-ID: <20130531214400.GA16362@bwidawsk.net> References: <20130531184616.GD11399@cantiga.alporthouse.com> <1370036780-13482-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.localdomain (unknown [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id 8FE62E5F11 for ; Fri, 31 May 2013 14:44:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1370036780-13482-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Intel GFX List-Id: intel-gfx@lists.freedesktop.org This should have been in reply to patch 2, sorry... On Fri, May 31, 2013 at 02:46:19PM -0700, Ben Widawsky wrote: > This makes it easier to catch leaks. > > Signed-off-by: Ben Widawsky > --- > drivers/gpu/drm/i915/i915_gem_stolen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c b/drivers/gpu/drm/i915/i915_gem_stolen.c > index 89cbfab..bc593e3 100644 > --- a/drivers/gpu/drm/i915/i915_gem_stolen.c > +++ b/drivers/gpu/drm/i915/i915_gem_stolen.c > @@ -279,7 +279,7 @@ _i915_gem_object_create_stolen(struct drm_device *dev, > goto cleanup; > > obj->has_dma_mapping = true; > - obj->pages_pin_count = 1; > + i915_gem_object_pin_pages(obj); > obj->stolen = stolen; > > obj->base.write_domain = I915_GEM_DOMAIN_GTT; > -- > 1.8.3 > -- Ben Widawsky, Intel Open Source Technology Center