From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915/sdvo: Use &intel_sdvo->ddc instead of intel_sdvo->i2c for DDC. Date: Tue, 4 Jun 2013 16:35:32 +0100 Message-ID: <20130604153532.GA5398@cantiga.alporthouse.com> References: <1370358801-305-1-git-send-email-eich@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (s16502780.onlinehome-server.info [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id 6533BE5C2F for ; Tue, 4 Jun 2013 08:35:47 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1370358801-305-1-git-send-email-eich@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Egbert Eich Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, Chris Wilson , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org On Tue, Jun 04, 2013 at 05:13:21PM +0200, Egbert Eich wrote: > In intel_sdvo_get_lvds_modes() the wrong i2c adapter record is used > for DDC. Thus the code will always have to rely on a LVDS panel > mode supplied by VBT. > In most cases this succeeds, so this didn't get detected for quite > a while. > > Signed-off-by: Egbert Eich Good catch! Cc: stable@vger.kernel.org Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre