From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 9/9] drm/i915: Assert dpll running in intel_crtc_load_lut() on pre-PCH platforms Date: Thu, 6 Jun 2013 13:59:15 +0200 Message-ID: <20130606115915.GD7827@phenom.ffwll.local> References: <1370342947-20757-1-git-send-email-ville.syrjala@linux.intel.com> <1370342947-20757-10-git-send-email-ville.syrjala@linux.intel.com> <20130605195806.GK5004@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ea0-f181.google.com (mail-ea0-f181.google.com [209.85.215.181]) by gabe.freedesktop.org (Postfix) with ESMTP id 1E166E5C12 for ; Thu, 6 Jun 2013 04:59:20 -0700 (PDT) Received: by mail-ea0-f181.google.com with SMTP id a15so152213eae.26 for ; Thu, 06 Jun 2013 04:59:19 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130605195806.GK5004@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Wed, Jun 05, 2013 at 10:58:06PM +0300, Ville Syrj=E4l=E4 wrote: > On Wed, Jun 05, 2013 at 04:41:54PM -0300, Rodrigo Vivi wrote: > > why is this needed? > = > The spec says that on some hardware you need to PLL running before you > can poke at the palette registers. I didn't actually try to anger the > hardware so I'm not really sure what would happen otherwise, but IIRC > Jesse said something about a hard system hang... I've added this to the commit message and merged the entire pile. Thanks for patches&review. -Daniel > = > > anyways: Reviewed-by: Rodrigo Vivi > > = > > On Tue, Jun 4, 2013 at 7:49 AM, wrote: > > > From: Ville Syrj=E4l=E4 > > > > > > Signed-off-by: Ville Syrj=E4l=E4 > > > --- > > > drivers/gpu/drm/i915/intel_display.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i= 915/intel_display.c > > > index 90d02c7..3be69bc 100644 > > > --- a/drivers/gpu/drm/i915/intel_display.c > > > +++ b/drivers/gpu/drm/i915/intel_display.c > > > @@ -6340,6 +6340,9 @@ void intel_crtc_load_lut(struct drm_crtc *crtc) > > > if (!crtc->enabled || !intel_crtc->active) > > > return; > > > > > > + if (!HAS_PCH_SPLIT(dev_priv->dev)) > > > + assert_pll_enabled(dev_priv, pipe); > > > + > > > /* use legacy palette for Ironlake */ > > > if (HAS_PCH_SPLIT(dev)) > > > palreg =3D LGC_PALETTE(pipe); > > > -- > > > 1.8.1.5 > > > > > > _______________________________________________ > > > Intel-gfx mailing list > > > Intel-gfx@lists.freedesktop.org > > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > = > > = > > = > > -- = > > Rodrigo Vivi > > Blog: http://blog.vivi.eng.br > = > -- = > Ville Syrj=E4l=E4 > Intel OTC > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch