From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: WA: FBC Render Nuke. Date: Thu, 6 Jun 2013 16:00:45 +0100 Message-ID: <20130606150045.GD20552@cantiga.alporthouse.com> References: <20130604080929.GA23294@cantiga.alporthouse.com> <1370530196-1712-1-git-send-email-rodrigo.vivi@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (s16502780.onlinehome-server.info [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id D7245E5F36 for ; Thu, 6 Jun 2013 08:00:57 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1370530196-1712-1-git-send-email-rodrigo.vivi@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Jun 06, 2013 at 11:49:56AM -0300, Rodrigo Vivi wrote: > WaFbcNukeOn3DBlt for IVB, HSW. > > According BSPec: "Workaround: Do not enable Render Command Streamer tracking for FBC. > Instead insert a LRI to address 0x50380 with data 0x00000004 after the PIPE_CONTROL that > follows each render submission." > > v2: Chris noticed that flush_domains check was missing here and also suggested to do > LRI only when fbc is enabled. To avoid do a I915_READ on every flush lets use the > module parameter check. > > v3: Adding Wa name as Damien suggested. > > v4: Ville noticed VLV doesn't support fbc at all and comment came wrong from spec. > > v5: Ville noticed than on blt a Cache Clean LRI should be used instead the Nuke one. > > v6: Check for flush domain on blt (by Ville). > Check for scanout dirty (by Chris). Note quite what I had in mind, see https://patchwork.kernel.org/patch/2606131/ -Chris -- Chris Wilson, Intel Open Source Technology Centre